Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel: log_impl tests #233

Merged
merged 1 commit into from
Mar 19, 2019
Merged

kernel: log_impl tests #233

merged 1 commit into from
Mar 19, 2019

Conversation

Orycterope
Copy link
Member

Fixes #66

roblabla
roblabla previously approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@roblabla roblabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and straightforward. I love it.

@roblabla
Copy link
Member

WRT clippy-ci fail: I think it's a matter of putting the use behind a #[cfg(test)]

@Orycterope Orycterope requested a review from marysaka March 19, 2019 18:28
roblabla
roblabla previously approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@roblabla roblabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

roblabla
roblabla reviewed Mar 19, 2019
View reviewed changes
Copy link
Member

@roblabla roblabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

roblabla
roblabla approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@roblabla roblabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@Orycterope Orycterope requested a review from roblabla March 19, 2019 18:36
@Orycterope Orycterope merged commit c047258 into sunriseos:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marysaka marysaka marysaka approved these changes

@roblabla roblabla Awaiting requested review from roblabla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Orycterope @roblabla @marysaka