Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report #[cfg(not(test))] and #[global_allocator] #67

Closed
todo bot opened this issue Dec 10, 2018 · 0 comments
Closed

report #[cfg(not(test))] and #[global_allocator] #67

todo bot opened this issue Dec 10, 2018 · 0 comments
Assignees
@Orycterope
Labels
todo 🗒️ Created by the todo bot

Comments

@todo
Copy link

todo bot commented Dec 10, 2018

`#[cfg(not(test))]` still compiles this item with cargo test, but `#[cfg(target_os = "none")] does not. I think this is a bug, we should report it.

https://github.com/roblabla42/KFS/blob/84f52da4950ee96188e38618b55d975a53609284/libuser/src/lib.rs#L36-L43

This issue was generated by todo based on a TODO comment in 84f52da when #63 was merged. cc @Orycterope.
@todo todo bot added the todo 🗒️ Created by the todo bot label Dec 10, 2018
Orycterope referenced this issue in Orycterope/SunriseOS Mar 13, 2019
@Orycterope
global_allocator_cfg_not_test
03c7d91 
Apparently this works now. Closes #67
@Orycterope Orycterope mentioned this issue Mar 13, 2019
Merged
roblabla pushed a commit to roblabla/KFS that referenced this issue Mar 16, 2019
@Orycterope @roblabla
global_allocator_cfg_not_test
dd18764 
Apparently this works now. Closes sunriseos#67
roblabla pushed a commit to roblabla/KFS that referenced this issue Mar 16, 2019
@Orycterope @roblabla
global_allocator_cfg_not_test
431b050 
Apparently this works now. Closes sunriseos#67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Orycterope Orycterope

Labels
todo 🗒️ Created by the todo bot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Orycterope