-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: NeuroML import and export fixes and enhancements #810
Draft
sanjayankur31
wants to merge
109
commits into
suny-downstate-medical-center:neuroml_updates
Choose a base branch
from
sanjayankur31:feat/neuroml-ankur
base: neuroml_updates
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: NeuroML import and export fixes and enhancements #810
sanjayankur31
wants to merge
109
commits into
suny-downstate-medical-center:neuroml_updates
from
sanjayankur31:feat/neuroml-ankur
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without it tests/ will be installed as a top level Python module.
…ate-medical-center/development PR from development to master - VERSION 1.0.5
More readable, and IDE friendly
I seem to be able to run NetPyNE sims fine with MPI, so this comment does not seem to apply any more.
See, override decoration helps :)
It's a warning that the user should be aware of.
erev is not required in Nernst or GHK2
Removing the minimumdescent=False from the call to TextArea
…medical-center#829) * batch tools subpackage merge into dev, see PR suny-downstate-medical-center#818 suny-downstate-medical-center#822 suny-downstate-medical-center#826 suny-downstate-medical-center#827 see documentation
…move-saveFileStep Remove saveFileStep
Hi @sanjayankur31, is this still WIP or it can be merged? |
…reilly/patch-1 Bug fix in scalebar - removing the use of the minimumdescent argument in the call to TextArea
…development Exlude tests from discovery / installation
…at has emerged with spack installation (EBRAINS platform). Will re-visit later.. This reverts commit e5aa9e8.
Still WIP I'm afraid. The bits are almost complete but we need to investigate differences in spike times b/w NeuroML's NetPyNE export and the NEURON export. |
…mplates (suny-downstate-medical-center#831) see netpyne.batchtools esp. submits.py and search.py slurm job submission: search() now supports job_type='slurm' with associated 'ifs' and 'socket' communication modes the run_config for these submission scripts should specify the following arguments: 'allocation' (allocation for the job) 'walltime' (time limit before job termination) 'nodes' (# nodes for job) 'coresPerNode' (number of cores per job--i.e. the mpiexec -n value) 'email' (user email) 'custom' (any custom commands to execute prior to sourcing ~/.bashrc) 'command' (execution of script, command to be run from the project directory to run the script) update to see submission: run_config for the submission now includes the following argument 'realtime' (time limit before job termination)
[skip ci]
This is only required if one modifies the keys of the dict while iterating over it, which we do not.
The same segment objects are used everywhere, so the segment object in `parent_seg` will also be the one used in the lists in `ordered_segs`. So, there's no need to iterate and compare ids, simply look if the object is in the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.