Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to conditionally hide/lock certain settings in the Query Loop block #2

Closed
Tracked by #42616
sunyatasattva opened this issue Aug 5, 2022 · 1 comment
Assignees

Comments

@sunyatasattva
Copy link
Owner

What problem does this address?

Currently the Query Loop block inspector shows a ton of settings which are great for flexibility, but might create an overwhelming user experience, especially when variations of the Query Loop block are created. Furthermore, those settings might even break said variations.

So, we would like a way to, not just collapse or temporarily hide the settings, but to completely remove them from the inspector.

What is your proposed solution?

We could add an extra attribute to the Query Loop block, something like disabledInspectorControls, that could receive an array of controls you want to avoid rendering in the inspector. This solution would maintain backwards compatibility (i.e. all controls are displayed by default), but would also create an opt-in way to disable certain problematic controls.

Meta

Story points: 8
COU: 5

@sunyatasattva sunyatasattva self-assigned this Aug 5, 2022
sunyatasattva pushed a commit that referenced this issue Aug 16, 2022
* Release script: Update react-native-aztec, react-native-bridge, and react-native-editor to version 1.72.0

* Release script: Update with changes from 'run native preios'

* Update release notes

* Add new changelog item

* Add new release note

* Release script: Update react-native-editor version to 1.72.1

* Release script: Update with changes from 'npm run core preios'

* Detect GIF as part of rendering (WordPress#39882)

* Add 1.72.1 section to changelog

* Empty commit to try and get CI unstuck

* Empty commit to try and get CI unstuck #2

Trying another one because GitHub's Actions were reporting problems on
the status dashboard before, but now the dashboard is green, so
:fingers-crossed:

Co-authored-by: jhnstn <jason@readysetandco.com>
Co-authored-by: Stefanos Togoulidis <stefanostogoulidis@gmail.com>
Co-authored-by: Matt Chowning <mchowning@gmail.com>
sunyatasattva pushed a commit that referenced this issue Aug 16, 2022
PHP 8.1 has deprecated passing null as the second parameter to `preg_match()`, generating the following Deprecated notice: `preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated`.
@sunyatasattva
Copy link
Owner Author

Closed in #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant