Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aspect ratio correction #15

Merged

Conversation

olafkryus
Copy link
Contributor

While it is true that the game used 320×200 px VGA video mode for graphics display, at the time of it's release all such software was meant to be displayed on a 4:3 CRT monitor. This pull request add an Alt+A keyboard shortcut for switching between the square-pixel 16:10 aspect ratio and the intended-but-stretched 4:3 aspect ratio. A similar option is available e.g. in the recent Android port of Deluxe Ski Jump 2 and works quite well there.

The default display mode is left unchanged, as without anti-aliasing the 4:3 mode looks rather wobbly at the default scaling ratio. However when aspect ratio correction is enabled on a 1600×1200 px display, it should give a nice and round 5:6 horizontal to vertical pixel scaling ratio, resulting in a sharp picture.

@veikkos
Copy link
Member

veikkos commented Dec 7, 2020

Thanks for the addition. I would rename the feature in console/readme to "Toggle 4:3 aspect ratio" or similar so that it's more describing.

@olafkryus olafkryus force-pushed the feature/aspect-ratio-correction branch from c551ff2 to d70868c Compare December 12, 2020 23:31
@olafkryus
Copy link
Contributor Author

That's a good point. I've changed the feature name in all places.

@veikkos veikkos merged commit 4c350f0 into suomipelit:master Dec 13, 2020
@veikkos
Copy link
Member

veikkos commented Dec 13, 2020

Thanks for this.

Are you @olafkryus planning to do other fixes? We could bundle all near future fixes in to single release.

@veikkos
Copy link
Member

veikkos commented Dec 20, 2020

Feature released in SJ313-SP4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants