Refresh schema UI as live share queries executed #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monitors wire protocol messages during a Live Share session and automatically updates the schema UI to reflect the current state.
Background
In order to update the schema UI, we need to query the PGlite instance (via pg-meta) to get the latest tables/columns. Since this requires executing SQL against the same PGlite instance that Live Share is communicating with, we need to be careful not to run this when the user is in the middle of set of protocol messages (eg. extended queries).
When is it safe?
We update the UI after detecting a
ReadyForQueryresponse from PGlite, which indicates that the current set of protocol messages have completed and a fresh query is safe to execute. We also ensure that the connection is not in the middle of a transaction by checking a transaction status flag sent with theReadyForQuerymessage.