Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New design #146

Merged
merged 35 commits into from
Dec 6, 2024
Merged

New design #146

merged 35 commits into from
Dec 6, 2024

Conversation

SaxonF
Copy link
Contributor

@SaxonF SaxonF commented Dec 5, 2024

What kind of change does this PR introduce?

Implement a new design.

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
database-build ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 10:36am

Copy link
Contributor

@jgoux jgoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Only a few comments but nothing blocking. 😄

Another thing I noticed is that when I have databases created and I go back to the app, we're on the "home" page with the sidebar closed. I guess it's because of the new design but I was confused for 2 sec not seeing my previously created databases by default. What would help I think is showing the sidebar by default if there are existing databases on the home screen.

On mobile, the database name is hidden in the header but I find it pretty important to identify which database I'm working with. I don't have a solution to provide as the header is already packed. 😅 I would probably push all the actions on the right to the "extra actions button" to gain some space and have the database name displayed instead. But that won't be trivial to implement for the "Deploy" button. 🤔

apps/web/app/deploy/[databaseId]/page.tsx Outdated Show resolved Hide resolved
apps/web/components/schema/empty-state-graph.tsx Outdated Show resolved Hide resolved
apps/web/components/sidebar/database-menu-item.tsx Outdated Show resolved Hide resolved
@gregnr gregnr merged commit c8441ac into main Dec 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants