feat: store deployed databases info in Supabase DB #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgoux
commented
Aug 8, 2024
jgoux
commented
Aug 8, 2024
gregnr
reviewed
Aug 14, 2024
| success: false, | ||
| error: "You can't deploy a database that is bigger than 100MB", | ||
| }, | ||
| { status: 413 } | ||
| ) | ||
| } | ||
|
|
||
| const databaseId = params.id | ||
| const key = `dbs/${databaseId}.tar.gz` | ||
|
|
||
| const gzip = createGzip() |
There was a problem hiding this comment.
I noticed that sometimes PGlite produced a non-gzipped tar file (not sure what caused this). Should we try to detect this somehow or check mime type?
There was a problem hiding this comment.
In my case it's the opposite, I never had PGlite produce a gzipped tarball, that's why I gzip it in the route here.
Should we ping Sam about it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the main changes:
sidebar.tsxinto multiple components so it's more manageabledeployed_databasestable in Supabase database to store the deployed databases infos