Merge pull request #17 from supabase-community/fix/pglite-error-hang

Add test for PGlite hanging after error message
supabase-community · Sep 23, 2024 · 0ed68f0 · 0ed68f0
2 parents 561fa36 + 87f2096
commit 0ed68f0
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 12 deletions.
diff --git a/deno.lock b/deno.lock
diff --git a/examples/pglite-auth/package.json b/examples/pglite-auth/package.json
@@ -7,7 +7,7 @@
     "type-check": "tsc --noEmit"
   },
   "dependencies": {
-    "@electric-sql/pglite": "^0.2.6",
+    "@electric-sql/pglite": "^0.2.7",
     "pg-gateway": "*"
   },
   "devDependencies": {

diff --git a/examples/pglite-multiple/package.json b/examples/pglite-multiple/package.json
@@ -8,7 +8,7 @@
     "type-check": "tsc --noEmit"
   },
   "dependencies": {
-    "@electric-sql/pglite": "^0.2.6",
+    "@electric-sql/pglite": "^0.2.7",
     "pg-gateway": "*"
   },
   "devDependencies": {

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/pg-gateway/test/deno/tcp.test.ts b/packages/pg-gateway/test/deno/tcp.test.ts
@@ -3,7 +3,7 @@ import pg from 'npm:pg';
 
 import { expect } from 'jsr:@std/expect';
 import { afterAll, beforeAll, describe, it } from 'jsr:@std/testing/bdd';
-import { PGlite } from 'npm:@electric-sql/pglite';
+import { PGlite } from 'npm:@electric-sql/pglite@^0.2.7';
 import { fromDenoConn } from 'pg-gateway/deno';
 
 const { Client } = pg;

diff --git a/packages/pg-gateway/test/node/pg.test.ts b/packages/pg-gateway/test/node/pg.test.ts
@@ -47,4 +47,15 @@ describe('pg client with pglite', () => {
     const [{ message }] = res.rows;
     expect(message).toBe('Hello world!');
   });
+
+  it('invalid sql throws an error but does not hang', async () => {
+    await using client = await connect();
+    const promise = client.query('invalid sql');
+    await expect(promise).rejects.toThrowError('syntax error at or near "invalid"');
+
+    // Run another query to see if the connection hung
+    const res = await client.query("select 'Hello world!' as message");
+    const [{ message }] = res.rows;
+    expect(message).toBe('Hello world!');
+  });
 });