Skip to content

fix: make sure range is correct for eof deletions #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2025
Merged

fix: make sure range is correct for eof deletions #311

merged 3 commits into from
Apr 4, 2025

Conversation

psteinroe
Copy link
Collaborator

fixes #303

juleswritescode
juleswritescode approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@juleswritescode juleswritescode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: wir testen create table "" hello, der user hatte create table "hello" – aber ist ja wahrscheinlich egal, right?

LGTM 👍

@psteinroe
Copy link
Collaborator Author

Ja, würde auch create "" gehen im Test

@psteinroe psteinroe merged commit 6f697bf into main Apr 4, 2025
7 checks passed
@psteinroe psteinroe mentioned this pull request Apr 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juleswritescode juleswritescode juleswritescode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assertion failed: start.raw <= end.raw
2 participants
@psteinroe @juleswritescode