fix: extract sql fn body properly #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
approved these changes
Apr 19, 2025
|
|
||
| let stmts = d.iter(DefaultMapper).collect::<Vec<_>>(); | ||
|
|
||
| assert_eq!(stmts.len(), 2); |
There was a problem hiding this comment.
Love it!
should we add a test asserting the content as well?
and maybe a test using the $$ notation?
There was a problem hiding this comment.
not really necessary imo - we can trust pg_query here
There was a problem hiding this comment.
will do it in a follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turns out I was so focused on the rewrite of that layer that I forgot to add even a single test for the sql fn body extraction 😢
fixes #342