tests: e2e test for analytics #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-2116 e2e test for analytics
Basic e2e tests to make we don't have have regressions in our analytics without knowing about it until much later |
jgoux
approved these changes
May 16, 2024
Comment on lines
+21
to
+24
| const now = | ||
| process.env["SNAPLET_NOW"] && !isNaN(+process.env["SNAPLET_NOW"]) | ||
| ? +process.env["SNAPLET_NOW"] | ||
| : Date.now(); |
There was a problem hiding this comment.
When I see code like this, I really understand the case for dependency injection. 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.