Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Span data to take advantage of the queries view in Sentry Performance #5

Open
smeubank opened this issue Feb 22, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@smeubank
Copy link

smeubank commented Feb 22, 2024

Feature request

As span data is set today, it will not appear in Sentry's Query Module.

image

Describe the solution you'd like

Span's must be set in the required format to display in the query module.

Describe alternatives you've considered

We should comply as much as possible from a client side PoV but it may also be reasonable to add db.supabase similar to db.prisma

Additional context

Specifically Operation should be

  • db.sql.query or other from list
  • db.system: postgresql
  • description should contain the SQL query
@smeubank smeubank added the enhancement New feature or request label Feb 22, 2024
@smeubank
Copy link
Author

in the case of Prism in relay, Sentry accepts a special case

from Kamil

For supabase there is no raw SQL query, so they use https://postgrest.org/en/v12/index.html

@smeubank
Copy link
Author

@kamilogorek what kind of cardinality should we expect with PostgREST

Is it parameterized by nature or within the integration in anyway?

@smeubank
Copy link
Author

@kamilogorek
Copy link
Contributor

@smeubank following up on this, it looks like there's no changes required now on the integration side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants