feat(spans): Parse supabase span descriptions #3153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olksdr
approved these changes
Feb 23, 2024
Dav1dde
approved these changes
Feb 23, 2024
| @@ -365,6 +365,12 @@ pub fn extract_tags( | |||
| } else { | |||
| None | |||
| } | |||
| } else if span.origin.as_str() == Some("auto.db.supabase") { | |||
| scrubbed_description.as_deref().map(|s| { | |||
| s.trim_start_matches("from(") | |||
There was a problem hiding this comment.
Should we enforce that this description always starts with from(?
There was a problem hiding this comment.
Thanks, this actually surfaced a bug, see follow-up here: #3156
jjbayer
added a commit
that referenced
this pull request
Feb 23, 2024
Follow-up for #3153: * Only accept `from(...)` * Accept table names without scrubbed identifiers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description only contains the table name, e.g.
"from(users)".In the future, we might want to parse
data.queryas well.See https://github.com/supabase-community/sentry-integration-js/blob/bae59de7e86c916d9396e2e2de55e6ac17e646d6/index.js#L259