Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken createSignedURL API #15

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Fix broken createSignedURL API #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1609cc
Fix create signed URL endpoint to include bucket ID
ryansburgoyne Dec 21, 2022
75f94eb
Fix returning of signed URL
ryansburgoyne Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Sources/SupabaseStorage/StorageFileApi.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public class StorageFileApi: StorageApi {
/// - expiresIn: The number of seconds until the signed URL expires. For example, `60` for a URL
/// which is valid for one minute.
public func createSignedURL(path: String, expiresIn: Int) async throws -> URL {
guard let url = URL(string: "\(url)/object/sign/\(path)") else {
guard let url = URL(string: "\(url)/object/sign/\(bucketId)/\(path)") else {
throw StorageError(message: "badURL")
}

Expand All @@ -118,11 +118,12 @@ public class StorageFileApi: StorageApi {
)
guard
let dict = response as? [String: Any],
let signedURL: String = dict["signedURL"] as? String
let signedURLString = dict["signedURL"] as? String,
let signedURL = URL(string: self.url.appending(signedURLString))
else {
throw StorageError(message: "failed to parse response")
}
return url.appendingPathComponent(signedURL)
return signedURL
}

/// Deletes files within the same bucket
Expand Down