Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs #42

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Fix bugs #42

merged 2 commits into from
Jan 20, 2021

Conversation

kiwicopple
Copy link
Member

@kiwicopple
Copy link
Member Author

pr: @thorwebdev | @soedirgo

TBH the "globalThis" is a new one to me.

#38 links to this: https://codesandbox.io/s/github/supabase/supabase/tree/master/examples/nextjs-todo-list

I suspect if globalThis isn't supported, perhaps localStorage isn't either? Not really sure what to do in these situations. Hopefully this is a step closer. #kaizen

@kiwicopple
Copy link
Member Author

Fixes:

supabase/supabase-js#113
supabase/supabase-js#89

soedirgo
soedirgo approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@soedirgo soedirgo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can polyfill localStorage, we probably won't need to polyfill globalThis since we can just use localStorage without fully qualifying it. But I can't find an isomorphic localStorage solution :/

There's node-localstorage but it's possible that the context is a browser that doesn't support localStorage.

thorwebdev
thorwebdev approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@thorwebdev thorwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL 🤯
LGTM

@kiwicopple kiwicopple mentioned this pull request Jan 16, 2021
Closed
@jhoch jhoch mentioned this pull request Jan 20, 2021
Closed
@kiwicopple kiwicopple merged commit 34051e7 into master Jan 20, 2021
@kiwicopple kiwicopple deleted the chore/fix_bugs branch January 20, 2021 01:39
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.10.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soedirgo soedirgo soedirgo approved these changes

@thorwebdev thorwebdev thorwebdev approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

process is not defined Fix globalThis for older browsers/Node environments
3 participants
@kiwicopple @thorwebdev @soedirgo