Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch padding for base64 #254

Merged
merged 3 commits into from
Mar 24, 2023
Merged

fix: patch padding for base64 #254

merged 3 commits into from
Mar 24, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Mar 23, 2023

fix proposed @kn

See #246 for details

Thanks kn!

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 23, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.68%.

Quality metrics Before After Change
Complexity 2.05 ⭐ 2.03 ⭐ -0.02 👍
Method Length 50.12 ⭐ 51.62 ⭐ 1.50 👎
Working memory 4.81 ⭐ 4.97 ⭐ 0.16 👎
Quality 85.38% 84.70% -0.68% 👎
Other metrics Before After Change
Lines 72 75 3
Changed files Quality Before Quality After Quality Change
gotrue/helpers.py 85.38% ⭐ 84.70% ⭐ -0.68% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (3476384) 37.60% compared to head (a37afe3) 37.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   37.60%   37.59%   -0.02%     
==========================================
  Files          25       25              
  Lines        2284     2285       +1     
==========================================
  Hits          859      859              
- Misses       1425     1426       +1     
Impacted Files Coverage Δ
gotrue/helpers.py 78.26% <0.00%> (-1.74%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@J0 J0 merged commit f77663a into main Mar 24, 2023
@J0 J0 deleted the j0/patch_padding_for_base64 branch March 24, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant