ci: add exhaustive switch statement linter (#1557)

Adds [a linter that checks for non-exhaustive `switch` statements](https://github.com/nishanths/exhaustive).
supabase · Apr 28, 2024 · 6ec08b3 · 6ec08b3
1 parent 2caa7b4
commit 6ec08b3
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 1 deletion.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -52,6 +52,7 @@ jobs:
         run: |
           set -x
           go install honnef.co/go/tools/cmd/staticcheck@latest
+          go install github.com/nishanths/exhaustive/cmd/exhaustive@latest
           make static
       - name: Check gosec
         run: |

diff --git a/Makefile b/Makefile
@@ -22,6 +22,7 @@ dev-deps: ## Install developer dependencies
 	@go install github.com/securego/gosec/v2/cmd/gosec@latest
 	@go install honnef.co/go/tools/cmd/staticcheck@latest
 	@go install github.com/deepmap/oapi-codegen/cmd/oapi-codegen@latest
+	@go install github.com/nishanths/exhaustive/cmd/exhaustive@latest
 
 deps: ## Install dependencies.
 	@go mod download
@@ -54,6 +55,7 @@ unused: dev-deps # Look for unused code
 
 static: dev-deps
 	staticcheck ./...
+	exhaustive ./...
 
 generate: dev-deps
 	go generate ./...

diff --git a/internal/api/logout.go b/internal/api/logout.go
@@ -48,6 +48,7 @@ func (a *API) Logout(w http.ResponseWriter, r *http.Request) error {
 			return terr
 		}
 
+		//exhaustive:ignore Default case is handled below.
 		switch scope {
 		case LogoutLocal:
 			return models.LogoutSession(tx, s.ID)

diff --git a/internal/observability/logging.go b/internal/observability/logging.go
@@ -91,7 +91,7 @@ func setPopLogger(sql string) {
 		}
 
 		switch lvl {
-		case logging.Debug:
+		case logging.SQL, logging.Debug:
 			l.Debug(s)
 		case logging.Info:
 			l.Info(s)