-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth.sms.test_otp w/ international numbers #1566
Comments
Hi @franzwarning I cannot reproduce your issue and the international format is supported (docs) |
To reproduce:
w/ a config.toml
It will try to use the provider instead of using the test_otp code. However, if you use a non-international number (just 9998887777), everything works. |
hey @franzwarning, thanks for reporting this, we've made a fix for it - the issue is due to the auth service not applying the same basic formatting rules for the test OTPs in the config but it does not affect the SMS delivery to the underlying provider used (the country code will be respected) |
Thank you for the fast response! |
## What kind of change does this PR introduce? * Apply basic formatting on test OTPs when config is loaded * Fixes #1566 ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
I facing error
how to set international number as test number? |
@choim4389 wrap the phone number in quotes as well |
## What kind of change does this PR introduce? * Apply basic formatting on test OTPs when config is loaded * Fixes supabase#1566 ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
## What kind of change does this PR introduce? * Apply basic formatting on test OTPs when config is loaded * Fixes supabase#1566 ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
## What kind of change does this PR introduce? * Apply basic formatting on test OTPs when config is loaded * Fixes supabase#1566 ## What is the current behavior? Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
Hi! I'm trying to use test_otp codes via
signInWithOtp
for international phone numbers, but it doesn't seem to work when I have a number that is prefixed with+1...
. Has anyone else seen this behaviour?The text was updated successfully, but these errors were encountered: