fix: omit empty string from name & use case-insensitive equality for comparing SAML attributes #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
changed the title
Pull Request Test Coverage Report for Build 9905453274Details
💛 - Coveralls |
J0
approved these changes
Jul 12, 2024
J0
pushed a commit
that referenced
this pull request
Jul 12, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.2](v2.155.1...v2.155.2) (2024-07-12) ### Bug Fixes * improve session error logging ([#1655](#1655)) ([5a6793e](5a6793e)) * omit empty string from name & use case-insensitive equality for comparing SAML attributes ([#1654](#1654)) ([bf5381a](bf5381a)) * set rate limit log level to warn ([#1652](#1652)) ([10ca9c8](10ca9c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
…comparing SAML attributes (supabase#1654) ## What kind of change does this PR introduce? * Fixes an issue where the SAML mapping is incorrect when a `Default` is specified in the mapping and the `FriendlyName` in the SAML Assertion is an empty string * Use case-insensitive equality for mapping SAML attributes * Tested with a trial okta account ## What is the current behavior? * During the SAML assertion process, the `SAMLAttributeMapping` struct defaults the `Name` to an empty string. When combined with a SAML assertion that has an empty string set in the `FriendlyName`, this causes an incorrect mapping when a default mapping is provided. (see [test case](https://github.com/supabase/auth/pull/1654/files#diff-e708a1335880a92063e8b45f3a06eb96931ab0ee46b94cdf6bf5f566640f7a3cR247-R272) * Use case-sensitive equality for mapping SAML attributes Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.2](supabase/auth@v2.155.1...v2.155.2) (2024-07-12) ### Bug Fixes * improve session error logging ([supabase#1655](supabase#1655)) ([5a6793e](supabase@5a6793e)) * omit empty string from name & use case-insensitive equality for comparing SAML attributes ([supabase#1654](supabase#1654)) ([bf5381a](supabase@bf5381a)) * set rate limit log level to warn ([supabase#1652](supabase#1652)) ([10ca9c8](supabase@10ca9c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
…comparing SAML attributes (supabase#1654) ## What kind of change does this PR introduce? * Fixes an issue where the SAML mapping is incorrect when a `Default` is specified in the mapping and the `FriendlyName` in the SAML Assertion is an empty string * Use case-insensitive equality for mapping SAML attributes * Tested with a trial okta account ## What is the current behavior? * During the SAML assertion process, the `SAMLAttributeMapping` struct defaults the `Name` to an empty string. When combined with a SAML assertion that has an empty string set in the `FriendlyName`, this causes an incorrect mapping when a default mapping is provided. (see [test case](https://github.com/supabase/auth/pull/1654/files#diff-e708a1335880a92063e8b45f3a06eb96931ab0ee46b94cdf6bf5f566640f7a3cR247-R272) * Use case-sensitive equality for mapping SAML attributes Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.2](supabase/auth@v2.155.1...v2.155.2) (2024-07-12) ### Bug Fixes * improve session error logging ([supabase#1655](supabase#1655)) ([5a6793e](supabase@5a6793e)) * omit empty string from name & use case-insensitive equality for comparing SAML attributes ([supabase#1654](supabase#1654)) ([bf5381a](supabase@bf5381a)) * set rate limit log level to warn ([supabase#1652](supabase#1652)) ([10ca9c8](supabase@10ca9c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
…comparing SAML attributes (supabase#1654) ## What kind of change does this PR introduce? * Fixes an issue where the SAML mapping is incorrect when a `Default` is specified in the mapping and the `FriendlyName` in the SAML Assertion is an empty string * Use case-insensitive equality for mapping SAML attributes * Tested with a trial okta account ## What is the current behavior? * During the SAML assertion process, the `SAMLAttributeMapping` struct defaults the `Name` to an empty string. When combined with a SAML assertion that has an empty string set in the `FriendlyName`, this causes an incorrect mapping when a default mapping is provided. (see [test case](https://github.com/supabase/auth/pull/1654/files#diff-e708a1335880a92063e8b45f3a06eb96931ab0ee46b94cdf6bf5f566640f7a3cR247-R272) * Use case-sensitive equality for mapping SAML attributes Please link any relevant issues here. ## What is the new behavior? Feel free to include screenshots if it includes visual changes. ## Additional context Add any other context or screenshots.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
🤖 I have created a release *beep* *boop* --- ## [2.155.2](supabase/auth@v2.155.1...v2.155.2) (2024-07-12) ### Bug Fixes * improve session error logging ([supabase#1655](supabase#1655)) ([5a6793e](supabase@5a6793e)) * omit empty string from name & use case-insensitive equality for comparing SAML attributes ([supabase#1654](supabase#1654)) ([bf5381a](supabase@bf5381a)) * set rate limit log level to warn ([supabase#1652](supabase#1652)) ([10ca9c8](supabase@10ca9c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Defaultis specified in the mapping and theFriendlyNamein the SAML Assertion is an empty stringWhat is the current behavior?
SAMLAttributeMappingstruct defaults theNameto an empty string. When combined with a SAML assertion that has an empty string set in theFriendlyName, this causes an incorrect mapping when a default mapping is provided. (see test casePlease link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.