Incorrect schema regex #1719
Comments
kangmingtay
pushed a commit
that referenced
this issue
Aug 19, 2024
## What kind of change does this PR introduce? Bug fix ## What is the current behavior? A valid provider name gets invalidated. ## What is the new behavior? A possible valid provider name gets verified by regex correctly. ## Additional context `[^a]+` -> This regex will match any char except character `a` `^a$` -> This regex will match string have single char `a` `^[a-zA-Z0-9]+$` -> This regex will match any alphanumeric string. `^` denotes start of string and `$` denotes end of string. This pull request will address #1719
|
@pauldemarco closing since this has been fixed by @hiteshbedre 🎉 |
uxodb
pushed a commit
to uxodb/auth
that referenced
this issue
Nov 13, 2024
## What kind of change does this PR introduce? Bug fix ## What is the current behavior? A valid provider name gets invalidated. ## What is the new behavior? A possible valid provider name gets verified by regex correctly. ## Additional context `[^a]+` -> This regex will match any char except character `a` `^a$` -> This regex will match string have single char `a` `^[a-zA-Z0-9]+$` -> This regex will match any alphanumeric string. `^` denotes start of string and `$` denotes end of string. This pull request will address supabase#1719
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this issue
Nov 13, 2024
## What kind of change does this PR introduce? Bug fix ## What is the current behavior? A valid provider name gets invalidated. ## What is the new behavior? A possible valid provider name gets verified by regex correctly. ## Additional context `[^a]+` -> This regex will match any char except character `a` `^a$` -> This regex will match string have single char `a` `^[a-zA-Z0-9]+$` -> This regex will match any alphanumeric string. `^` denotes start of string and `$` denotes end of string. This pull request will address supabase#1719
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this issue
Nov 15, 2024
## What kind of change does this PR introduce? Bug fix ## What is the current behavior? A valid provider name gets invalidated. ## What is the new behavior? A possible valid provider name gets verified by regex correctly. ## Additional context `[^a]+` -> This regex will match any char except character `a` `^a$` -> This regex will match string have single char `a` `^[a-zA-Z0-9]+$` -> This regex will match any alphanumeric string. `^` denotes start of string and `$` denotes end of string. This pull request will address supabase#1719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
^character will disallow any of the characters within the group.This should be removed to allow for providers names like
google.auth/openapi.yaml
Line 285 in 4b04327
The text was updated successfully, but these errors were encountered: