Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if session is nil #1873

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix: check if session is nil #1873

merged 1 commit into from
Dec 13, 2024

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Log a message if the session is nil

@kangmingtay kangmingtay requested a review from a team as a code owner December 13, 2024 08:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12311840881

Details

  • 8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 57.263%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/logout.go 8 9 88.89%
Totals Coverage Status
Change from base Build 12308620792: 0.004%
Covered Lines: 9709
Relevant Lines: 16955

💛 - Coveralls

@hf hf merged commit fd82601 into master Dec 13, 2024
3 checks passed
@hf hf deleted the km/fix-panic-logout branch December 13, 2024 09:24
@hf hf mentioned this pull request Dec 13, 2024
hf pushed a commit that referenced this pull request Dec 23, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.165.1](v2.165.0...v2.165.1)
(2024-12-19)


### Bug Fixes

* check if session is nil
([#1873](#1873))
([fd82601](fd82601))
* email_verified field not being updated on signup confirmation
([#1868](#1868))
([483463e](483463e))
* handle user banned error code
([#1851](#1851))
([a6918f4](a6918f4))
* Revert "fix: revert fallback on btree indexes when hash is
unavailable" ([#1859](#1859))
([9fe5b1e](9fe5b1e))
* skip cleanup for non-2xx status
([#1877](#1877))
([f572ced](f572ced))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
hf pushed a commit that referenced this pull request Dec 23, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.166.0](v2.165.0...v2.166.0)
(2024-12-23)


### Features

* switch to googleapis/release-please-action, bump to 2.166.0
([#1883](#1883))
([11a312f](11a312f))


### Bug Fixes

* check if session is nil
([#1873](#1873))
([fd82601](fd82601))
* email_verified field not being updated on signup confirmation
([#1868](#1868))
([483463e](483463e))
* handle user banned error code
([#1851](#1851))
([a6918f4](a6918f4))
* Revert "fix: revert fallback on btree indexes when hash is
unavailable" ([#1859](#1859))
([9fe5b1e](9fe5b1e))
* skip cleanup for non-2xx status
([#1877](#1877))
([f572ced](f572ced))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants