Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: idempotent logout #1870

Closed
wants to merge 1 commit into from
Closed

fix: idempotent logout #1870

wants to merge 1 commit into from

Conversation

hf
Copy link
Contributor

@hf hf commented Dec 12, 2024

If there's no user or session when calling logout, the action should be successful.

@hf
fix: idempotent logout
796320f 
If there's no user or session when calling logout, the action should be successful.
@hf hf requested a review from a team as a code owner December 12, 2024 17:21
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12301506592

Details

  • 1 of 6 (16.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 57.252%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/logout.go 1 6 16.67%
Totals Coverage Status
Change from base Build 12290043590: -0.01%
Covered Lines: 9707
Relevant Lines: 16955
💛 - Coveralls

cstockton
cstockton approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@cstockton cstockton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, eventually I think getSession and getUser should have boolean or error return values.

@hf
Copy link
Contributor Author

hf commented Dec 13, 2024

Handled differently in #1873

@hf hf closed this Dec 13, 2024
@hf hf deleted the hf/fix-idempotent-logout branch December 13, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstockton cstockton cstockton approved these changes

@J0 J0 J0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hf @coveralls @cstockton @J0