Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only create or update the email / phone identity after it's been verified (again) #1409

Merged
merged 1 commit into from
Feb 8, 2024
Merged

fix: only create or update the email / phone identity after it's been verified (again) #1409

merged 1 commit into from
Feb 8, 2024

Conversation

kangmingtay
Copy link
Member

@kangmingtay kangmingtay commented Feb 8, 2024 •
edited by hf
Loading

What kind of change does this PR introduce?

  • We only want to create / update the email / phone identity after it's been verified during the email change / phone change flow
  • Previously, the email / phone identity was created / updated immediately after the user update endpoint is called. This results in the identity being created before it's been confirmed.

Like #1403, but adding again.

@kangmingtay kangmingtay requested a review from a team as a code owner February 8, 2024 17:16
@hf hf force-pushed the km/revert-revert-fix-email-change branch from 6d0e96f to 723423d Compare February 8, 2024 17:29
@hf hf changed the title revert: revert fix email change fix: only create or update the email / phone identity after it's been verified (again) Feb 8, 2024
@hf hf merged commit bc6a5b8 into master Feb 8, 2024
4 checks passed
@hf hf deleted the km/revert-revert-fix-email-change branch February 8, 2024 17:34
@github-actions github-actions bot mentioned this pull request Feb 8, 2024
Merged
J0 pushed a commit that referenced this pull request Feb 12, 2024
@github-actions
chore(master): release 2.139.2 (#1395)
a48b348 
🤖 I have created a release *beep* *boop*
---


##
[2.139.2](v2.139.1...v2.139.2)
(2024-02-08)


### Bug Fixes

* improve perf in account linking
([#1394](#1394))
([8eedb95](8eedb95))
* OIDC provider validation log message
([#1380](#1380))
([27e6b1f](27e6b1f))
* only create or update the email / phone identity after it's been
verified ([#1403](#1403))
([2d20729](2d20729))
* only create or update the email / phone identity after it's been
verified (again)
([#1409](#1409))
([bc6a5b8](bc6a5b8))
* unmarshal is_private_email correctly
([#1402](#1402))
([47df151](47df151))
* use `pattern` for semver docker image tags
([#1411](#1411))
([14a3aeb](14a3aeb))


### Reverts

* "fix: only create or update the email / phone identity after i…
([#1407](#1407))
([ff86849](ff86849))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@kangmingtay kangmingtay mentioned this pull request Feb 14, 2024
Merged
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@kangmingtay
fix: only create or update the email / phone identity after it's been…
81b349d 
… verified (again) (supabase#1409)

## What kind of change does this PR introduce?
* We only want to create / update the email / phone identity after it's
been verified during the email change / phone change flow
* Previously, the email / phone identity was created / updated
immediately after the user update endpoint is called. This results in
the identity being created before it's been confirmed.

Like supabase#1403, but adding again.
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@github-actions
chore(master): release 2.139.2 (supabase#1395)
a8b76eb 
🤖 I have created a release *beep* *boop*
---


##
[2.139.2](supabase/auth@v2.139.1...v2.139.2)
(2024-02-08)


### Bug Fixes

* improve perf in account linking
([supabase#1394](supabase#1394))
([8eedb95](supabase@8eedb95))
* OIDC provider validation log message
([supabase#1380](supabase#1380))
([27e6b1f](supabase@27e6b1f))
* only create or update the email / phone identity after it's been
verified ([supabase#1403](supabase#1403))
([2d20729](supabase@2d20729))
* only create or update the email / phone identity after it's been
verified (again)
([supabase#1409](supabase#1409))
([bc6a5b8](supabase@bc6a5b8))
* unmarshal is_private_email correctly
([supabase#1402](supabase#1402))
([47df151](supabase@47df151))
* use `pattern` for semver docker image tags
([supabase#1411](supabase#1411))
([14a3aeb](supabase@14a3aeb))


### Reverts

* "fix: only create or update the email / phone identity after i…
([supabase#1407](supabase#1407))
([ff86849](supabase@ff86849))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@kangmingtay @LashaJini
fix: only create or update the email / phone identity after it's been…
30fe596 
… verified (again) (supabase#1409)

## What kind of change does this PR introduce?
* We only want to create / update the email / phone identity after it's
been verified during the email change / phone change flow
* Previously, the email / phone identity was created / updated
immediately after the user update endpoint is called. This results in
the identity being created before it's been confirmed.

Like supabase#1403, but adding again.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@github-actions @LashaJini
chore(master): release 2.139.2 (supabase#1395)
d6f5744 
🤖 I have created a release *beep* *boop*
---


##
[2.139.2](supabase/auth@v2.139.1...v2.139.2)
(2024-02-08)


### Bug Fixes

* improve perf in account linking
([supabase#1394](supabase#1394))
([8eedb95](supabase@8eedb95))
* OIDC provider validation log message
([supabase#1380](supabase#1380))
([27e6b1f](supabase@27e6b1f))
* only create or update the email / phone identity after it's been
verified ([supabase#1403](supabase#1403))
([2d20729](supabase@2d20729))
* only create or update the email / phone identity after it's been
verified (again)
([supabase#1409](supabase#1409))
([bc6a5b8](supabase@bc6a5b8))
* unmarshal is_private_email correctly
([supabase#1402](supabase#1402))
([47df151](supabase@47df151))
* use `pattern` for semver docker image tags
([supabase#1411](supabase#1411))
([14a3aeb](supabase@14a3aeb))


### Reverts

* "fix: only create or update the email / phone identity after i…
([supabase#1407](supabase#1407))
([ff86849](supabase@ff86849))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@kangmingtay @LashaJini
fix: only create or update the email / phone identity after it's been…
f89c9f2 
… verified (again) (supabase#1409)

## What kind of change does this PR introduce?
* We only want to create / update the email / phone identity after it's
been verified during the email change / phone change flow
* Previously, the email / phone identity was created / updated
immediately after the user update endpoint is called. This results in
the identity being created before it's been confirmed.

Like supabase#1403, but adding again.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@github-actions @LashaJini
chore(master): release 2.139.2 (supabase#1395)
0931e8f 
🤖 I have created a release *beep* *boop*
---


##
[2.139.2](supabase/auth@v2.139.1...v2.139.2)
(2024-02-08)


### Bug Fixes

* improve perf in account linking
([supabase#1394](supabase#1394))
([8eedb95](supabase@8eedb95))
* OIDC provider validation log message
([supabase#1380](supabase#1380))
([27e6b1f](supabase@27e6b1f))
* only create or update the email / phone identity after it's been
verified ([supabase#1403](supabase#1403))
([2d20729](supabase@2d20729))
* only create or update the email / phone identity after it's been
verified (again)
([supabase#1409](supabase#1409))
([bc6a5b8](supabase@bc6a5b8))
* unmarshal is_private_email correctly
([supabase#1402](supabase#1402))
([47df151](supabase@47df151))
* use `pattern` for semver docker image tags
([supabase#1411](supabase#1411))
([14a3aeb](supabase@14a3aeb))


### Reverts

* "fix: only create or update the email / phone identity after i…
([supabase#1407](supabase#1407))
([ff86849](supabase@ff86849))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf hf hf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kangmingtay @hf