ci: add explicit release version in docker build #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
approved these changes
Feb 8, 2024
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
Publishing builds the image, but the Makefile uses `git describe --tags` for the version if the `RELEASE_VERSION` env var is not defined. And this is an issue because the `.git` directory is not included in the image (and it shouldn't be). Furthermore, the describe tags does not reflect the proper version name.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
Publishing builds the image, but the Makefile uses `git describe --tags` for the version if the `RELEASE_VERSION` env var is not defined. And this is an issue because the `.git` directory is not included in the image (and it shouldn't be). Furthermore, the describe tags does not reflect the proper version name.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
Publishing builds the image, but the Makefile uses `git describe --tags` for the version if the `RELEASE_VERSION` env var is not defined. And this is an issue because the `.git` directory is not included in the image (and it shouldn't be). Furthermore, the describe tags does not reflect the proper version name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing builds the image, but the Makefile uses
git describe --tagsfor the version if theRELEASE_VERSIONenv var is not defined. And this is an issue because the.gitdirectory is not included in the image (and it shouldn't be). Furthermore, the describe tags does not reflect the proper version name.