feat: use dummy instance id to improve performance on refresh token queries #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
changed the title
J0
changed the title
J0
force-pushed
the
j0/use_index_on_refresh_token
branch
from
0248a62 to
7c750fd
Compare
kangmingtay
approved these changes
Mar 4, 2024
hf
pushed a commit
that referenced
this pull request
Mar 5, 2024
🤖 I have created a release *beep* *boop* --- ## [2.144.0](v2.143.0...v2.144.0) (2024-03-04) ### Features * add configuration for custom sms sender hook ([#1428](#1428)) ([1ea56b6](1ea56b6)) * anonymous sign-ins ([#1460](#1460)) ([130df16](130df16)) * clean up test setup in MFA tests ([#1452](#1452)) ([7185af8](7185af8)) * pass transaction to `invokeHook`, fixing pool exhaustion ([#1465](#1465)) ([b536d36](b536d36)) * refactor resource owner password grant ([#1443](#1443)) ([e63ad6f](e63ad6f)) * use dummy instance id to improve performance on refresh token queries ([#1454](#1454)) ([656474e](656474e)) ### Bug Fixes * expose `provider` under `amr` in access token ([#1456](#1456)) ([e9f38e7](e9f38e7)) * improve MFA QR Code resilience so as to support providers like 1Password ([#1455](#1455)) ([6522780](6522780)) * refactor request params to use generics ([#1464](#1464)) ([e1cdf5c](e1cdf5c)) * revert refactor resource owner password grant ([#1466](#1466)) ([fa21244](fa21244)) * update file name so migration to Drop IP Address is applied ([#1447](#1447)) ([f29e89d](f29e89d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
…ueries (supabase#1454) ## What kind of change does this PR introduce? Use the nil instance ID so that we can leverage the compound index on instance_id and user_id when performing search and deletion Aims to address supabase#1449 and supabase#1398. We note that `LogoutAllRefreshTokens` was marked as deprecated and may be possible to remove if all access tokens now have a `sessionId`. Additionally, `FindTokenBySessionID` can likely be replaced by using `FindCurrentlyActiveRefreshToken`. We will revisit these in a week or two but they are out of scope for this PR. Co-authored-by: joel <joel@joels-MacBook-Pro.local>
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.144.0](supabase/auth@v2.143.0...v2.144.0) (2024-03-04) ### Features * add configuration for custom sms sender hook ([supabase#1428](supabase#1428)) ([1ea56b6](supabase@1ea56b6)) * anonymous sign-ins ([supabase#1460](supabase#1460)) ([130df16](supabase@130df16)) * clean up test setup in MFA tests ([supabase#1452](supabase#1452)) ([7185af8](supabase@7185af8)) * pass transaction to `invokeHook`, fixing pool exhaustion ([supabase#1465](supabase#1465)) ([b536d36](supabase@b536d36)) * refactor resource owner password grant ([supabase#1443](supabase#1443)) ([e63ad6f](supabase@e63ad6f)) * use dummy instance id to improve performance on refresh token queries ([supabase#1454](supabase#1454)) ([656474e](supabase@656474e)) ### Bug Fixes * expose `provider` under `amr` in access token ([supabase#1456](supabase#1456)) ([e9f38e7](supabase@e9f38e7)) * improve MFA QR Code resilience so as to support providers like 1Password ([supabase#1455](supabase#1455)) ([6522780](supabase@6522780)) * refactor request params to use generics ([supabase#1464](supabase#1464)) ([e1cdf5c](supabase@e1cdf5c)) * revert refactor resource owner password grant ([supabase#1466](supabase#1466)) ([fa21244](supabase@fa21244)) * update file name so migration to Drop IP Address is applied ([supabase#1447](supabase#1447)) ([f29e89d](supabase@f29e89d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
…ueries (supabase#1454) ## What kind of change does this PR introduce? Use the nil instance ID so that we can leverage the compound index on instance_id and user_id when performing search and deletion Aims to address supabase#1449 and supabase#1398. We note that `LogoutAllRefreshTokens` was marked as deprecated and may be possible to remove if all access tokens now have a `sessionId`. Additionally, `FindTokenBySessionID` can likely be replaced by using `FindCurrentlyActiveRefreshToken`. We will revisit these in a week or two but they are out of scope for this PR. Co-authored-by: joel <joel@joels-MacBook-Pro.local>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.144.0](supabase/auth@v2.143.0...v2.144.0) (2024-03-04) ### Features * add configuration for custom sms sender hook ([supabase#1428](supabase#1428)) ([1ea56b6](supabase@1ea56b6)) * anonymous sign-ins ([supabase#1460](supabase#1460)) ([130df16](supabase@130df16)) * clean up test setup in MFA tests ([supabase#1452](supabase#1452)) ([7185af8](supabase@7185af8)) * pass transaction to `invokeHook`, fixing pool exhaustion ([supabase#1465](supabase#1465)) ([b536d36](supabase@b536d36)) * refactor resource owner password grant ([supabase#1443](supabase#1443)) ([e63ad6f](supabase@e63ad6f)) * use dummy instance id to improve performance on refresh token queries ([supabase#1454](supabase#1454)) ([656474e](supabase@656474e)) ### Bug Fixes * expose `provider` under `amr` in access token ([supabase#1456](supabase#1456)) ([e9f38e7](supabase@e9f38e7)) * improve MFA QR Code resilience so as to support providers like 1Password ([supabase#1455](supabase#1455)) ([6522780](supabase@6522780)) * refactor request params to use generics ([supabase#1464](supabase#1464)) ([e1cdf5c](supabase@e1cdf5c)) * revert refactor resource owner password grant ([supabase#1466](supabase#1466)) ([fa21244](supabase@fa21244)) * update file name so migration to Drop IP Address is applied ([supabase#1447](supabase#1447)) ([f29e89d](supabase@f29e89d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
…ueries (supabase#1454) ## What kind of change does this PR introduce? Use the nil instance ID so that we can leverage the compound index on instance_id and user_id when performing search and deletion Aims to address supabase#1449 and supabase#1398. We note that `LogoutAllRefreshTokens` was marked as deprecated and may be possible to remove if all access tokens now have a `sessionId`. Additionally, `FindTokenBySessionID` can likely be replaced by using `FindCurrentlyActiveRefreshToken`. We will revisit these in a week or two but they are out of scope for this PR. Co-authored-by: joel <joel@joels-MacBook-Pro.local>
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
🤖 I have created a release *beep* *boop* --- ## [2.144.0](supabase/auth@v2.143.0...v2.144.0) (2024-03-04) ### Features * add configuration for custom sms sender hook ([supabase#1428](supabase#1428)) ([1ea56b6](supabase@1ea56b6)) * anonymous sign-ins ([supabase#1460](supabase#1460)) ([130df16](supabase@130df16)) * clean up test setup in MFA tests ([supabase#1452](supabase#1452)) ([7185af8](supabase@7185af8)) * pass transaction to `invokeHook`, fixing pool exhaustion ([supabase#1465](supabase#1465)) ([b536d36](supabase@b536d36)) * refactor resource owner password grant ([supabase#1443](supabase#1443)) ([e63ad6f](supabase@e63ad6f)) * use dummy instance id to improve performance on refresh token queries ([supabase#1454](supabase#1454)) ([656474e](supabase@656474e)) ### Bug Fixes * expose `provider` under `amr` in access token ([supabase#1456](supabase#1456)) ([e9f38e7](supabase@e9f38e7)) * improve MFA QR Code resilience so as to support providers like 1Password ([supabase#1455](supabase#1455)) ([6522780](supabase@6522780)) * refactor request params to use generics ([supabase#1464](supabase#1464)) ([e1cdf5c](supabase@e1cdf5c)) * revert refactor resource owner password grant ([supabase#1466](supabase#1466)) ([fa21244](supabase@fa21244)) * update file name so migration to Drop IP Address is applied ([supabase#1447](supabase#1447)) ([f29e89d](supabase@f29e89d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Use the nil instance ID so that we can leverage the compound index on instance_id and user_id when performing search and deletion
Aims to address #1449 and #1398.
We note that
LogoutAllRefreshTokenswas marked as deprecated and may be possible to remove if all access tokens now have asessionId. Additionally,FindTokenBySessionIDcan likely be replaced by usingFindCurrentlyActiveRefreshToken.We will revisit these in a week or two but they are out of scope for this PR.