-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow aliases on local development #1524
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 8623798274Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we make the hostname an internal config option which we can set? makes it easier to update as well
b86179f
to
f2422a2
Compare
Pull Request Test Coverage Report for Build 11798245254Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
3e3661b
to
427823d
Compare
What kind of change does this PR introduce?
Allow developers to use aliases such as kong and edge_functions for local development as
host.docker.internal
might not be compatible on all platformsLink: supabase/cli#2129 (comment)
By default, we allow the following HTTP HostNames: localhost, 127.0.0.1, ::1, host.docker.internal.