Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invited users should have a temporary password generated #1644

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix: invited users should have a temporary password generated #1644

merged 1 commit into from
Jul 3, 2024

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Fixes a bug in the boolean condition where an invited user fails to have their password updated to a temporary password on invite confirmation

@kangmingtay kangmingtay requested a review from a team as a code owner July 3, 2024 17:48
@coveralls
Copy link

coveralls commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9782555197

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 57.775%
Totals Coverage Status
Change from base Build 9767637889: 0.03%
Covered Lines: 8731
Relevant Lines: 15112
💛 - Coveralls

J0
J0 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can consider setting should shouldUpdatePassword to !user.HasPassword() && user.InvitedAt != nil

I think it's also fine as is though

@kangmingtay kangmingtay merged commit 3f70d9d into master Jul 3, 2024
3 checks passed
@kangmingtay kangmingtay deleted the km/fix-signup-verify branch July 3, 2024 19:12
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Merged
J0 pushed a commit that referenced this pull request Jul 3, 2024
@github-actions
chore(master): release 2.155.0 (#1640)
85361b7 
🤖 I have created a release *beep* *boop*
---


##
[2.155.0](v2.154.2...v2.155.0)
(2024-07-03)


### Features

* add `password_hash` and `id` fields to admin create user
([#1641](#1641))
([20d59f1](20d59f1))


### Bug Fixes

* improve mfa verify logs
([#1635](#1635))
([d8b47f9](d8b47f9))
* invited users should have a temporary password generated
([#1644](#1644))
([3f70d9d](3f70d9d))
* upgrade golang-jwt to v5
([#1639](#1639))
([2cb97f0](2cb97f0))
* use pointer for `user.EncryptedPassword`
([#1637](#1637))
([bbecbd6](bbecbd6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@kangmingtay
fix: invited users should have a temporary password generated (supaba…
17acd59 
…se#1644)

## What kind of change does this PR introduce?
* Fixes a bug in the boolean condition where an invited user fails to
have their password updated to a temporary password on invite
confirmation
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@github-actions
chore(master): release 2.155.0 (supabase#1640)
ebeb521 
🤖 I have created a release *beep* *boop*
---


##
[2.155.0](supabase/auth@v2.154.2...v2.155.0)
(2024-07-03)


### Features

* add `password_hash` and `id` fields to admin create user
([supabase#1641](supabase#1641))
([20d59f1](supabase@20d59f1))


### Bug Fixes

* improve mfa verify logs
([supabase#1635](supabase#1635))
([d8b47f9](supabase@d8b47f9))
* invited users should have a temporary password generated
([supabase#1644](supabase#1644))
([3f70d9d](supabase@3f70d9d))
* upgrade golang-jwt to v5
([supabase#1639](supabase#1639))
([2cb97f0](supabase@2cb97f0))
* use pointer for `user.EncryptedPassword`
([supabase#1637](supabase#1637))
([bbecbd6](supabase@bbecbd6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@kangmingtay @LashaJini
fix: invited users should have a temporary password generated (supaba…
c124c2d 
…se#1644)

## What kind of change does this PR introduce?
* Fixes a bug in the boolean condition where an invited user fails to
have their password updated to a temporary password on invite
confirmation
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@github-actions @LashaJini
chore(master): release 2.155.0 (supabase#1640)
d018e5b 
🤖 I have created a release *beep* *boop*
---


##
[2.155.0](supabase/auth@v2.154.2...v2.155.0)
(2024-07-03)


### Features

* add `password_hash` and `id` fields to admin create user
([supabase#1641](supabase#1641))
([20d59f1](supabase@20d59f1))


### Bug Fixes

* improve mfa verify logs
([supabase#1635](supabase#1635))
([d8b47f9](supabase@d8b47f9))
* invited users should have a temporary password generated
([supabase#1644](supabase#1644))
([3f70d9d](supabase@3f70d9d))
* upgrade golang-jwt to v5
([supabase#1639](supabase#1639))
([2cb97f0](supabase@2cb97f0))
* use pointer for `user.EncryptedPassword`
([supabase#1637](supabase#1637))
([bbecbd6](supabase@bbecbd6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@kangmingtay @LashaJini
fix: invited users should have a temporary password generated (supaba…
367cb54 
…se#1644)

## What kind of change does this PR introduce?
* Fixes a bug in the boolean condition where an invited user fails to
have their password updated to a temporary password on invite
confirmation
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@github-actions @LashaJini
chore(master): release 2.155.0 (supabase#1640)
e8263ed 
🤖 I have created a release *beep* *boop*
---


##
[2.155.0](supabase/auth@v2.154.2...v2.155.0)
(2024-07-03)


### Features

* add `password_hash` and `id` fields to admin create user
([supabase#1641](supabase#1641))
([20d59f1](supabase@20d59f1))


### Bug Fixes

* improve mfa verify logs
([supabase#1635](supabase#1635))
([d8b47f9](supabase@d8b47f9))
* invited users should have a temporary password generated
([supabase#1644](supabase#1644))
([3f70d9d](supabase@3f70d9d))
* upgrade golang-jwt to v5
([supabase#1639](supabase#1639))
([2cb97f0](supabase@2cb97f0))
* use pointer for `user.EncryptedPassword`
([supabase#1637](supabase#1637))
([bbecbd6](supabase@bbecbd6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J0 J0 J0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kangmingtay @coveralls @J0