Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add hook log entry with run_hook action #1684

Merged
merged 1 commit into from
Jul 29, 2024
Merged

feat: add hook log entry with run_hook action #1684

merged 1 commit into from
Jul 29, 2024

Conversation

hf
Copy link
Contributor

@hf hf commented Jul 28, 2024

Adds a log entry when hooks run. Also refactors the invokeHook API to not require redundant parameters like the URI.

@hf hf requested a review from a team as a code owner July 28, 2024 09:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10139474576

Details

  • 36 of 37 (97.3%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 58.193%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/mail.go 0 1 0.0%
Totals Coverage Status
Change from base Build 10113639694: 0.06%
Covered Lines: 8957
Relevant Lines: 15392
💛 - Coveralls

@hf hf merged commit 46491b8 into master Jul 29, 2024
2 checks passed
@hf hf deleted the hf/hook-log branch July 29, 2024 14:44
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
Merged
J0 pushed a commit that referenced this pull request Jul 31, 2024
@github-actions
chore(master): release 2.158.0 (#1686)
4aef63f 
🤖 I have created a release *beep* *boop*
---


##
[2.158.0](v2.157.0...v2.158.0)
(2024-07-31)


### Features

* add hook log entry with `run_hook` action
([#1684](#1684))
([46491b8](46491b8))
* MFA (Phone) ([#1668](#1668))
([ae091aa](ae091aa))


### Bug Fixes

* maintain backward compatibility for asymmetric JWTs
([#1690](#1690))
([0ad1402](0ad1402))
* MFA NewFactor to default to creating unverfied factors
([#1692](#1692))
([3d448fa](3d448fa))
* minor spelling errors
([#1688](#1688))
([6aca52b](6aca52b)),
closes [#1682](#1682)
* treat `GOTRUE_MFA_ENABLED` as meaning TOTP enabled on enroll and
verify ([#1694](#1694))
([8015251](8015251))
* update mfa phone migration to be idempotent
([#1687](#1687))
([fdff1e7](fdff1e7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@hf
feat: add hook log entry with run_hook action (supabase#1684)
2b1c70d 
Adds a log entry when hooks run. Also refactors the `invokeHook` API to
not require redundant parameters like the URI.
uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
@github-actions
chore(master): release 2.158.0 (supabase#1686)
86c1336 
🤖 I have created a release *beep* *boop*
---


##
[2.158.0](supabase/auth@v2.157.0...v2.158.0)
(2024-07-31)


### Features

* add hook log entry with `run_hook` action
([supabase#1684](supabase#1684))
([46491b8](supabase@46491b8))
* MFA (Phone) ([supabase#1668](supabase#1668))
([ae091aa](supabase@ae091aa))


### Bug Fixes

* maintain backward compatibility for asymmetric JWTs
([supabase#1690](supabase#1690))
([0ad1402](supabase@0ad1402))
* MFA NewFactor to default to creating unverfied factors
([supabase#1692](supabase#1692))
([3d448fa](supabase@3d448fa))
* minor spelling errors
([supabase#1688](supabase#1688))
([6aca52b](supabase@6aca52b)),
closes [supabase#1682](supabase#1682)
* treat `GOTRUE_MFA_ENABLED` as meaning TOTP enabled on enroll and
verify ([supabase#1694](supabase#1694))
([8015251](supabase@8015251))
* update mfa phone migration to be idempotent
([supabase#1687](supabase#1687))
([fdff1e7](supabase@fdff1e7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@hf @LashaJini
feat: add hook log entry with run_hook action (supabase#1684)
5d633ed 
Adds a log entry when hooks run. Also refactors the `invokeHook` API to
not require redundant parameters like the URI.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 13, 2024
@github-actions @LashaJini
chore(master): release 2.158.0 (supabase#1686)
9aa2ca6 
🤖 I have created a release *beep* *boop*
---


##
[2.158.0](supabase/auth@v2.157.0...v2.158.0)
(2024-07-31)


### Features

* add hook log entry with `run_hook` action
([supabase#1684](supabase#1684))
([46491b8](supabase@46491b8))
* MFA (Phone) ([supabase#1668](supabase#1668))
([ae091aa](supabase@ae091aa))


### Bug Fixes

* maintain backward compatibility for asymmetric JWTs
([supabase#1690](supabase#1690))
([0ad1402](supabase@0ad1402))
* MFA NewFactor to default to creating unverfied factors
([supabase#1692](supabase#1692))
([3d448fa](supabase@3d448fa))
* minor spelling errors
([supabase#1688](supabase#1688))
([6aca52b](supabase@6aca52b)),
closes [supabase#1682](supabase#1682)
* treat `GOTRUE_MFA_ENABLED` as meaning TOTP enabled on enroll and
verify ([supabase#1694](supabase#1694))
([8015251](supabase@8015251))
* update mfa phone migration to be idempotent
([supabase#1687](supabase#1687))
([fdff1e7](supabase@fdff1e7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@hf @LashaJini
feat: add hook log entry with run_hook action (supabase#1684)
e9d191b 
Adds a log entry when hooks run. Also refactors the `invokeHook` API to
not require redundant parameters like the URI.
LashaJini pushed a commit to LashaJini/auth that referenced this pull request Nov 15, 2024
@github-actions @LashaJini
chore(master): release 2.158.0 (supabase#1686)
ea4537f 
🤖 I have created a release *beep* *boop*
---


##
[2.158.0](supabase/auth@v2.157.0...v2.158.0)
(2024-07-31)


### Features

* add hook log entry with `run_hook` action
([supabase#1684](supabase#1684))
([46491b8](supabase@46491b8))
* MFA (Phone) ([supabase#1668](supabase#1668))
([ae091aa](supabase@ae091aa))


### Bug Fixes

* maintain backward compatibility for asymmetric JWTs
([supabase#1690](supabase#1690))
([0ad1402](supabase@0ad1402))
* MFA NewFactor to default to creating unverfied factors
([supabase#1692](supabase#1692))
([3d448fa](supabase@3d448fa))
* minor spelling errors
([supabase#1688](supabase#1688))
([6aca52b](supabase@6aca52b)),
closes [supabase#1682](supabase#1682)
* treat `GOTRUE_MFA_ENABLED` as meaning TOTP enabled on enroll and
verify ([supabase#1694](supabase#1694))
([8015251](supabase@8015251))
* update mfa phone migration to be idempotent
([supabase#1687](supabase#1687))
([fdff1e7](supabase@fdff1e7))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J0 J0 J0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hf @coveralls @J0