Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: maintain backward compatibility for asymmetric JWTs #1695

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

## What kind of change does this PR introduce?
* Use the original value of `GOTRUE_JWT_SECRET` - no need to check for
base64 decoding.
* Don't include the kid claim if the kid is an empty string

## What is the current behavior?

Please link any relevant issues here.

## What is the new behavior?

Feel free to include screenshots if it includes visual changes.

## Additional context

Add any other context or screenshots.
@kangmingtay kangmingtay requested a review from a team as a code owner July 31, 2024 15:34
@github-actions github-actions bot force-pushed the release-please--branches--master branch from 863f9a9 to c66dd30 Compare July 31, 2024 15:36
@kangmingtay kangmingtay changed the base branch from release-please--branches--master to release/2.157.0 July 31, 2024 15:37
@kangmingtay kangmingtay changed the title chore: release 2.157.1 fix: maintain backward compatibility for asymmetric JWTs Jul 31, 2024
@kangmingtay kangmingtay merged commit cbb84b8 into release/2.157.0 Jul 31, 2024
4 checks passed
@kangmingtay kangmingtay deleted the km/v2.157.1 branch July 31, 2024 15:41
kangmingtay pushed a commit that referenced this pull request Jul 31, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.157.1](v2.157.0...v2.157.1)
(2024-07-31)


### Bug Fixes

* maintain backward compatibility for asymmetric JWTs
([#1695](#1695))
([cbb84b8](cbb84b8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants