feat: fix large group claim handling in azure id tokens #1995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
commented
Apr 19, 2025
hf
commented
Apr 19, 2025
Pull Request Test Coverage Report for Build 14550997722Details
💛 - Coveralls |
cstockton
approved these changes
Apr 21, 2025
Contributor
cstockton
left a comment
cstockton
left a comment
There was a problem hiding this comment.
Approving since high priority.
I do wonder how many claims end up needing resolved this way? It may be worth having the http request code in an errgroup because depending on latency it might really add up. Being in a func scope would have the additional benefit of more eager defers.
hf
pushed a commit
that referenced
this pull request
May 5, 2025
🤖 I have created a release *beep* *boop* --- ## [2.172.0](v2.171.0...v2.172.0) (2025-05-04) ### Features * fix large group claim handling in azure id tokens ([#1995](#1995)) ([2f323fe](2f323fe)) * use `global_user_id` over `sub` for `vercel_marketplace` issuer ([#1990](#1990)) ([f94f97e](f94f97e)) ### Bug Fixes * azure overage claims start with single `_` not two ([#1999](#1999)) ([29f3440](29f3440)) * remove azure claim overage code. ([#2005](#2005)) ([63dce14](63dce14)) * resolving azure overage claim should include `api-version=1.6` query parameter ([#2000](#2000)) ([44890d0](44890d0)) * upgrade godotenv to v1.5.1 to fix multiline file loading ([#1997](#1997)) ([f2af4b2](f2af4b2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wdoppenberg
pushed a commit
to wdoppenberg/supabase-auth
that referenced
this pull request
Jun 5, 2025
Handles [large `group` claims in Azure ID tokens](https://learn.microsoft.com/en-us/entra/identity-platform/id-token-claims-reference#groups-overage-claim) by fetching them from the ([usually](https://learn.microsoft.com/en-us/graph/api/directoryobject-getmemberobjects?view=graph-rest-1.0&tabs=http)) designated Azure endpoint.
cemalkilic
pushed a commit
that referenced
this pull request
Aug 7, 2025
Handles [large `group` claims in Azure ID tokens](https://learn.microsoft.com/en-us/entra/identity-platform/id-token-claims-reference#groups-overage-claim) by fetching them from the ([usually](https://learn.microsoft.com/en-us/graph/api/directoryobject-getmemberobjects?view=graph-rest-1.0&tabs=http)) designated Azure endpoint.
cemalkilic
pushed a commit
that referenced
this pull request
Aug 7, 2025
🤖 I have created a release *beep* *boop* --- ## [2.172.0](v2.171.0...v2.172.0) (2025-05-04) ### Features * fix large group claim handling in azure id tokens ([#1995](#1995)) ([2f323fe](2f323fe)) * use `global_user_id` over `sub` for `vercel_marketplace` issuer ([#1990](#1990)) ([f94f97e](f94f97e)) ### Bug Fixes * azure overage claims start with single `_` not two ([#1999](#1999)) ([29f3440](29f3440)) * remove azure claim overage code. ([#2005](#2005)) ([63dce14](63dce14)) * resolving azure overage claim should include `api-version=1.6` query parameter ([#2000](#2000)) ([44890d0](44890d0)) * upgrade godotenv to v1.5.1 to fix multiline file loading ([#1997](#1997)) ([f2af4b2](f2af4b2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
issuedat
pushed a commit
that referenced
this pull request
Sep 30, 2025
Handles [large `group` claims in Azure ID tokens](https://learn.microsoft.com/en-us/entra/identity-platform/id-token-claims-reference#groups-overage-claim) by fetching them from the ([usually](https://learn.microsoft.com/en-us/graph/api/directoryobject-getmemberobjects?view=graph-rest-1.0&tabs=http)) designated Azure endpoint.
issuedat
pushed a commit
that referenced
this pull request
Sep 30, 2025
🤖 I have created a release *beep* *boop* --- ## [2.172.0](v2.171.0...v2.172.0) (2025-05-04) ### Features * fix large group claim handling in azure id tokens ([#1995](#1995)) ([2f323fe](2f323fe)) * use `global_user_id` over `sub` for `vercel_marketplace` issuer ([#1990](#1990)) ([f94f97e](f94f97e)) ### Bug Fixes * azure overage claims start with single `_` not two ([#1999](#1999)) ([29f3440](29f3440)) * remove azure claim overage code. ([#2005](#2005)) ([63dce14](63dce14)) * resolving azure overage claim should include `api-version=1.6` query parameter ([#2000](#2000)) ([44890d0](44890d0)) * upgrade godotenv to v1.5.1 to fix multiline file loading ([#1997](#1997)) ([f2af4b2](f2af4b2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles large
groupclaims in Azure ID tokens by fetching them from the (usually) designated Azure endpoint.