feat: hooks round 5 (Option 1) - add before-user-created hook

[cstockton]

Hooks Round 5 - Option 1

This PR contains Option 1 for implementing the before-user-created hook. See #2034 for option 2.

Summary

This commit explores one possible implementation of this hook by:

• Adding a triggerBeforeUserCreated to the *API object
• Updating signupNewUser to accept an *http.Request param
• Updating the following files with param r:
  • anonymous.go
  • external.go
  • invite.go
  • mail.go
  • signup.go
• Calling triggerBeforeUserCreated from signupNewUser

Pros:

• Very minor change
• Requires minimal testing
• This pattern will be easy to replicate for future hooks as well

Cons:

• Requires calling the hook in a transaction, something we do today but want to move away from over time.

Note:
I've omitted tests from this commit but they have already been written in a previous pr.

Depends on

feat: hooks round 1 - prepare package structure

• renamed pkg internal/hooks/v0hooks/v0http -> internal/hooks/hookshttp 8a398ab
• renamed pkg internal/hooks/v0hooks/v0pgfunc -> internal/hooks/hookspgfunc 8a398ab
• use pkg internal/e2e for test setup in:
  • pkg internal/hooks/hookspgfunc 4d60288
  • pkg internal/hooks/v0hooks 4a7432b

feat: hooks round 2 - remove indirection and simplify error handling

• update pkg internal/api to:
  • uses internal/hooks/v0hooks.Manager instead of internal/hooks/hooks.Manager aec5995
• remove pkg internal/hooks/hooks.Manager 062da5d
• add pkg internal/hooks/hookserrors 7e80afc
• use pkg internal/hooks/hookserrors in internal/hooks/v0hooks 57744e8
• update pkg internal/hooks/v0hooks with an Enabled method 16cc4c9

feat: hooks round 3 - begin adding the Before and After user created hooks

• update pkg internal/conf d5f5436
  • add BeforeUserCreated and AfterUserCreated to HookConfiguration struct
  • add test cases for EmailValidationBlockedMX to restore 100% test coverage
• update pkg internal/hooks/v0hooks bd37fe2
  • add BeforeUserCreated method to v0hooks.Manager struct
  • add AfterUserCreated method to v0hooks.Manager struct
  • add tests to reach 100% coverage
• add pkg internal/e2e/e2ehooks 903e623
  • add HookCall to record calls to hooks
  • add Hook struct to hold []*HookCall for a given hook name
  • add HookRecorder to hold one Hook object per hook name
  • add Instance struct to hold the httptest.Server and HookRecorder
  • add AfterUserCreated method to v0hooks.Manager struct
  • add tests to reach 100% coverage in all internal/e2e packages
• update pkg internal/hooks/v0hooks 829aec6
  • fix struct and json tag to match to match the Metadata type
• update pkg internal/hooks/v0hooks ca67be0
  • remove BeforeUserCreated and AfterUserCreated methods
  • add Before & After user created hooks in InvokeHook
• update pkg internal/e2e/e2eapi 46c144e
  • add comments in IOError tests involving http.RoundTripper
  • update calls to t.Fatal to use require

feat: hooks round 4 - update tests to use require package

• use pkg require for tests in: f2b3600
  • pkg internal/e2e/...
  • pkg internal/hooks/...

[coveralls]

Pull Request Test Coverage Report for Build 15169693367

Details

• 11 of 17 (64.71%) changed or added relevant lines in 6 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.01%) to 70.003%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/api/mail.go	1	2	50.0%
internal/api/signup.go	3	5	60.0%
internal/api/hooks.go	4	7	57.14%

Totals
Change from base Build 15141341085:	-0.01%
Covered Lines:	11134
Relevant Lines:	15905

---

💛 - Coveralls

[cstockton]

This approach is being closed as we are going with Option 2.