Skip to content

Conversation

@hf
Copy link
Contributor

@hf hf commented Jun 11, 2025

Apple seems to have swapped the issuer without notice from https://appleid.apple.com to https://account.apple.com

@hf hf requested a review from a team as a code owner June 11, 2025 02:47
@hf hf force-pushed the hf/fix-apple-oidc-issuer-change branch from de8545c to bbfe3b9 Compare June 11, 2025 03:08
@hf hf changed the title fix: accept ID tokens from all .apple.com issuers fix: accept ID tokens from all account.apple.com Jun 11, 2025
@hf hf changed the title fix: accept ID tokens from all account.apple.com fix: accept ID tokens from all account.apple.com and appleid.apple.com Jun 11, 2025
@hf hf merged commit 82aa167 into master Jun 11, 2025
8 checks passed
@hf hf deleted the hf/fix-apple-oidc-issuer-change branch June 11, 2025 03:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15575104731

Details

  • 5 of 35 (14.29%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 70.143%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/provider/oidc.go 1 2 50.0%
internal/api/token_oidc.go 0 12 0.0%
internal/api/provider/apple.go 4 21 19.05%
Totals Coverage Status
Change from base Build 15475144987: -0.1%
Covered Lines: 11340
Relevant Lines: 16167

💛 - Coveralls

hf pushed a commit that referenced this pull request Jun 11, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.176.0](v2.175.0...v2.176.0)
(2025-06-11)


### Features

* Add custom claims from Keycloak user token
([#1917](#1917))
([1365aaa](1365aaa))


### Bug Fixes

* accept ID tokens from all `account.apple.com` and `appleid.apple.com`
([#2050](#2050))
([82aa167](82aa167))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cemalkilic pushed a commit that referenced this pull request Aug 7, 2025
cemalkilic pushed a commit that referenced this pull request Aug 7, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.176.0](v2.175.0...v2.176.0)
(2025-06-11)


### Features

* Add custom claims from Keycloak user token
([#1917](#1917))
([1365aaa](1365aaa))


### Bug Fixes

* accept ID tokens from all `account.apple.com` and `appleid.apple.com`
([#2050](#2050))
([82aa167](82aa167))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
issuedat pushed a commit that referenced this pull request Sep 30, 2025
issuedat pushed a commit that referenced this pull request Sep 30, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.176.0](v2.175.0...v2.176.0)
(2025-06-11)


### Features

* Add custom claims from Keycloak user token
([#1917](#1917))
([1365aaa](1365aaa))


### Bug Fixes

* accept ID tokens from all `account.apple.com` and `appleid.apple.com`
([#2050](#2050))
([82aa167](82aa167))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants