fix: new odic.Provider for apple with insecure issuer url context
#2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
approved these changes
Jun 11, 2025
Pull Request Test Coverage Report for Build 15576299483Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
hf
pushed a commit
that referenced
this pull request
Jun 11, 2025
🤖 I have created a release *beep* *boop* --- ## [2.176.1](v2.176.0...v2.176.1) (2025-06-11) ### Bug Fixes * new `odic.Provider` for apple with insecure issuer url context ([#2055](#2055)) ([23d69f1](23d69f1)) * skip apple oidc issuer check ([#2053](#2053)) ([1c6f18e](1c6f18e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cemalkilic
pushed a commit
that referenced
this pull request
Aug 7, 2025
…2055) Apple's ID tokens sometimes say `https://appleid.apple.com` but the well-known URL returns that the issuer should be `https://account.apple.com`.
cemalkilic
pushed a commit
that referenced
this pull request
Aug 7, 2025
🤖 I have created a release *beep* *boop* --- ## [2.176.1](v2.176.0...v2.176.1) (2025-06-11) ### Bug Fixes * new `odic.Provider` for apple with insecure issuer url context ([#2055](#2055)) ([23d69f1](23d69f1)) * skip apple oidc issuer check ([#2053](#2053)) ([1c6f18e](1c6f18e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
issuedat
pushed a commit
that referenced
this pull request
Sep 30, 2025
…2055) Apple's ID tokens sometimes say `https://appleid.apple.com` but the well-known URL returns that the issuer should be `https://account.apple.com`.
issuedat
pushed a commit
that referenced
this pull request
Sep 30, 2025
🤖 I have created a release *beep* *boop* --- ## [2.176.1](v2.176.0...v2.176.1) (2025-06-11) ### Bug Fixes * new `odic.Provider` for apple with insecure issuer url context ([#2055](#2055)) ([23d69f1](23d69f1)) * skip apple oidc issuer check ([#2053](#2053)) ([1c6f18e](1c6f18e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple's ID tokens sometimes say
https://appleid.apple.combut the well-known URL returns that the issuer should behttps://account.apple.com.