Skip to content

Conversation

@cemalkilic
Copy link
Contributor

@cemalkilic cemalkilic commented Jul 16, 2025

What kind of change does this PR introduce?

nonce matching isn't supported for facebook limited login, skipping it during OIDC login. finalizes #2046

@cemalkilic cemalkilic requested a review from a team as a code owner July 16, 2025 08:51
@coveralls
Copy link

coveralls commented Jul 16, 2025

Pull Request Test Coverage Report for Build 16340911299

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 70.156%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/token_oidc.go 0 2 0.0%
Totals Coverage Status
Change from base Build 16138358707: -0.009%
Covered Lines: 11514
Relevant Lines: 16412

💛 - Coveralls

@cemalkilic cemalkilic merged commit f1b15ff into master Jul 17, 2025
5 checks passed
@cemalkilic cemalkilic deleted the cemal/feat-facebook-limited-login-skip-nonce-check branch July 17, 2025 09:25
cemalkilic pushed a commit that referenced this pull request Aug 6, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.178.0](v2.177.0...v2.178.0)
(2025-08-05)


### Features

* add sign in with ethereum
([#2069](#2069))
([079b242](079b242))
* add support for managing SSO providers by resource_id
([#2081](#2081))
([5ca4489](5ca4489))
* log all audit events separately to prevent missing events
([#2086](#2086))
([3b666f5](3b666f5))
* skip nonce check for Facebook Limited Login auth
([#2082](#2082))
([f1b15ff](f1b15ff))
* support ledger solana offchain message signing
([#2093](#2093))
([4c94443](4c94443))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cemalkilic added a commit that referenced this pull request Aug 7, 2025
## What kind of change does this PR introduce?

nonce matching isn't supported for facebook limited login, skipping it
during OIDC login. finalizes #2046
issuedat pushed a commit that referenced this pull request Sep 30, 2025
## What kind of change does this PR introduce?

nonce matching isn't supported for facebook limited login, skipping it
during OIDC login. finalizes #2046
issuedat pushed a commit that referenced this pull request Sep 30, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.178.0](v2.177.0...v2.178.0)
(2025-08-05)


### Features

* add sign in with ethereum
([#2069](#2069))
([079b242](079b242))
* add support for managing SSO providers by resource_id
([#2081](#2081))
([5ca4489](5ca4489))
* log all audit events separately to prevent missing events
([#2086](#2086))
([3b666f5](3b666f5))
* skip nonce check for Facebook Limited Login auth
([#2082](#2082))
([f1b15ff](f1b15ff))
* support ledger solana offchain message signing
([#2093](#2093))
([4c94443](4c94443))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants