fix: magiclink & recover verification should send login instead of signup action #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kangmingtay
commented
Feb 24, 2022
kangmingtay
commented
- Currently, the verification for a magiclink / recover sends a sign up action to the audit_log_entries table.
- We should be sending a login action instead.
J0
approved these changes
Feb 24, 2022
|
🎉 This PR is included in version 2.5.15 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
bnjmnt4n
reviewed
Feb 24, 2022
| @@ -200,7 +200,7 @@ func (a *API) recoverVerify(ctx context.Context, conn *storage.Connection, user | |||
| return terr | |||
| } | |||
| if !user.IsConfirmed() { | |||
| if terr = models.NewAuditLogEntry(tx, instanceID, user, models.UserSignedUpAction, nil); terr != nil { | |||
| if terr = models.NewAuditLogEntry(tx, instanceID, user, models.LoginAction, nil); terr != nil { | |||
There was a problem hiding this comment.
Wouldn't the user signed up action be correct since it's guarded by the !user.IsConfirmed() check? Maybe a separate audit log entry should be made with the login action if the user is confirmed?
There was a problem hiding this comment.
hmm good point, yeah i overlooked this, let me make a change! thanks for catching this 🔥
bnjmnt4n
added a commit
to bnjmnt4n/gotrue
that referenced
this pull request
Mar 23, 2022
…firmed This fixes a leftover bug following PRs supabase#395 and supabase#396.
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
…firmed (supabase#423) This fixes a leftover bug following PRs supabase#395 and supabase#396.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
…firmed (supabase#423) This fixes a leftover bug following PRs supabase#395 and supabase#396.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
…firmed (supabase#423) This fixes a leftover bug following PRs supabase#395 and supabase#396.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.