fix: allow user to update phone number #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
commented
Mar 21, 2022
| @@ -29,39 +34,51 @@ func (a *API) formatPhoneNumber(phone string) string { | |||
| return strings.ReplaceAll(strings.Trim(phone, "+"), " ", "") | |||
| } | |||
|
|
|||
| func (a *API) sendPhoneConfirmation(ctx context.Context, tx *storage.Connection, user *models.User, phone string) error { | |||
| // sendPhoneConfirmation sends an otp to the user's phone number | |||
| func (a *API) sendPhoneConfirmation(ctx context.Context, tx *storage.Connection, user *models.User, phone, otpType string, smsProvider sms_provider.SmsProvider) error { | |||
There was a problem hiding this comment.
Changed the function signature here to take in an otpType and a smsProvider. The smsProvider was added to the function params to make it easier to test this function with a mock sms provider that implements a stub SendSms method. See TestSendPhoneConfirmation.
J0
reviewed
Mar 22, 2022
J0
approved these changes
Mar 22, 2022
J0
reviewed
Mar 22, 2022
|
LGTM, thanks for the PR! |
|
🎉 This PR is included in version 2.6.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
awalias
added a commit
that referenced
this pull request
Nov 17, 2022
kangmingtay
pushed a commit
that referenced
this pull request
Nov 17, 2022
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
* refactor: sendPhoneConfirmation should accept an otpType and smsProvider * fix: allow update phone for users endpoint * fix: add phone change verification method
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
update README docs for supabase#421
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
* refactor: sendPhoneConfirmation should accept an otpType and smsProvider * fix: allow update phone for users endpoint * fix: add phone change verification method
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
update README docs for supabase#421
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
* refactor: sendPhoneConfirmation should accept an otpType and smsProvider * fix: allow update phone for users endpoint * fix: add phone change verification method
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
update README docs for supabase#421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
GOTRUE_SMS_AUTOCONFIRMis enabled, an otp will not be sent to the new phone number, else, an otp will be sent to the new phone number and the user has to verify it first.phone_changewhich when set, will verify if the token sent is valid when compared to thephone_change_tokenandphone_change_sent_atfieldsTo-Do
phone_changeverification type (https://github.com/supabase/gotrue-js/blob/master/src/lib/types.ts#L202)