Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Keycloak OpenID endpoint url #532

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Edit Keycloak OpenID endpoint url #532

merged 2 commits into from
Jul 5, 2022

Conversation

expandboard
Copy link
Contributor

What kind of change does this PR introduce?

OpenID Endpoint Configuration as mentioned in realm admin panel is not included '/auth/' in URL. keycloak documents describe endpoint URLs.

EXTERNAL_KEYCLOAK_URL = https://keycloak.example.com/auth/realms/myrealm IS NOT Correct.
EXTERNAL_KEYCLOAK_URL = https://keycloak.example.com/realms/myrealm IS Correct.

Bug fix, feature, docs update, ...

What is the current behavior?

Readme show a bad URL example.
Please link any relevant issues here.

What is the new behavior?

This PR can help users to have a better deploy without confusion.
Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

Keycloak URL is not included /auth/ after hostname. Readme file and description has a mistake.
@J0
Copy link
Contributor

J0 commented Jul 5, 2022

Thanks for spotting this and filing the PR! Seems like this was updated in later versions of Keycloak

@J0 J0 self-requested a review July 5, 2022 08:39
@J0 J0 merged commit bc44b28 into supabase:master Jul 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

🎉 This PR is included in version 2.7.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

uxodb pushed a commit to uxodb/auth that referenced this pull request Nov 13, 2024
Edit Keycloak OpenID endpoint url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants