feat: remove id_token flow with freeform provider
#927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
approved these changes
Feb 1, 2023
J0
approved these changes
Feb 2, 2023
|
🎉 This PR is included in version 2.44.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Feb 3, 2023
Closed
hf
added a commit
that referenced
this pull request
Feb 6, 2023
Reverts #927 due to identifying that some users do actually use this API but only for Apple and Google. I'll come back with another PR that blocks non-Apple and Google issuers only.
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
The `POST /token?grant_type=id_token` implementation allowed any OpenID Connect compliant issuer to be used for authentication, albeit in a very limited and broken way. Given we are not supporting this at this time, the implementation is being removed. Existing OIDC providers, importantly `google` and `apple` continue to be supported.
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
…e#933) Reverts supabase#927 due to identifying that some users do actually use this API but only for Apple and Google. I'll come back with another PR that blocks non-Apple and Google issuers only.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
The `POST /token?grant_type=id_token` implementation allowed any OpenID Connect compliant issuer to be used for authentication, albeit in a very limited and broken way. Given we are not supporting this at this time, the implementation is being removed. Existing OIDC providers, importantly `google` and `apple` continue to be supported.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 13, 2024
…e#933) Reverts supabase#927 due to identifying that some users do actually use this API but only for Apple and Google. I'll come back with another PR that blocks non-Apple and Google issuers only.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
The `POST /token?grant_type=id_token` implementation allowed any OpenID Connect compliant issuer to be used for authentication, albeit in a very limited and broken way. Given we are not supporting this at this time, the implementation is being removed. Existing OIDC providers, importantly `google` and `apple` continue to be supported.
LashaJini
pushed a commit
to LashaJini/auth
that referenced
this pull request
Nov 15, 2024
…e#933) Reverts supabase#927 due to identifying that some users do actually use this API but only for Apple and Google. I'll come back with another PR that blocks non-Apple and Google issuers only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
POST /token?grant_type=id_tokenimplementation allowed any OpenID Connect compliant issuer to be used for authentication, albeit in a very limited and broken way. Given we are not supporting this at this time, the implementation is being removed.Existing OIDC providers, importantly
googleandapplecontinue to be supported.