Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(functions): create new reader for retrying deploy #2840

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Nov 6, 2024

What kind of change does this PR introduce?

Bug fix #2837

What is the new behavior?

When initiating a retry, reusing the buffer reader results in 0 length body. Instantiate a new reader instead.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11700207355

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 59.803%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11700146494: -0.03%
Covered Lines: 6375
Relevant Lines: 10660

💛 - Coveralls

@sweatybridge sweatybridge merged commit 5bd2b61 into develop Nov 6, 2024
9 checks passed
@sweatybridge sweatybridge deleted the fix-retry branch November 6, 2024 08:58
@github-actions github-actions bot mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI doesn't show an error when Edge Functions bundle size is above the limit
2 participants