Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip seeding for disabled remote #2856

Merged
merged 3 commits into from
Nov 8, 2024
Merged

fix: skip seeding for disabled remote #2856

merged 3 commits into from
Nov 8, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Nov 8, 2024

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Allows disabling [db.seed] via [remotes] config.

Additional context

Add any other context or screenshots.

@coveralls
Copy link

coveralls commented Nov 8, 2024

Pull Request Test Coverage Report for Build 11736880515

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 59.798%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/db/push/push.go 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 11735605791: -0.03%
Covered Lines: 6384
Relevant Lines: 10676

💛 - Coveralls

@sweatybridge sweatybridge merged commit 8f2cdde into develop Nov 8, 2024
9 checks passed
@sweatybridge sweatybridge deleted the skip-seed branch November 8, 2024 06:04
@github-actions github-actions bot mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants