Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update docker id before db pull #3320

Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix: update docker id before db pull #3320

merged 1 commit into from
Mar 18, 2025

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Mar 18, 2025 •
edited
Loading

What kind of change does this PR introduce?

Bug fix #3306

What is the new behavior?

When parsing --db-url flag, docker id should be loaded with config file.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner March 18, 2025 23:48
@sweatybridge sweatybridge merged commit c5d40f7 into develop Mar 18, 2025
9 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13935674269

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.06%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/utils/flags/db_url.go 0 1 0.0%
Totals Coverage Status
Change from base Build 13918644911: 0.0%
Covered Lines: 6959
Relevant Lines: 13629
💛 - Coveralls

@sweatybridge sweatybridge deleted the fix-pull branch March 18, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sweatybridge @coveralls