Skip to content

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Oct 10, 2025

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

Treat shadow database the same way as connecting to local.

Additional context

This was causing errors when diffing schemas because TLS was attempted on a local port.

@sweatybridge sweatybridge requested a review from a team as a code owner October 10, 2025 09:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18403081701

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 54.67%

Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 80.61%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 18398164401: -0.03%
Covered Lines: 6409
Relevant Lines: 11723

💛 - Coveralls

@sweatybridge sweatybridge merged commit 4785f7a into develop Oct 10, 2025
20 checks passed
@sweatybridge sweatybridge deleted the fix-check branch October 10, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants