Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow setting static patterns when creating a user worker #471

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

laktek
Copy link
Contributor

@laktek laktek commented Jan 9, 2025

What kind of change does this PR introduce?

Currently, static file patterns (ie. static files that can be added to the eszip bundles) can be specified only via CLI flag --static. This PR modifies create options for user worker to support providing static patterns.

@laktek laktek requested a review from nyannyacha January 9, 2025 00:56
@nyannyacha
Copy link
Collaborator

nyannyacha commented Jan 9, 2025

Everything looks fine.

However, the indention of examples/main/index.ts seems to be a tab. (It seems that all .ts files added to this PR are formatted as a tab)

Can you fix it? (Starting with the Deno 2.1 LTS codebase, formatting rules will be applied to all files)

console.log('main worker exiting');

@laktek laktek requested a review from nyannyacha January 9, 2025 04:21
Copy link
Collaborator

@nyannyacha nyannyacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laktek laktek merged commit d2c21c1 into main Jan 9, 2025
3 checks passed
@laktek laktek deleted the static-patterns-for-user-worker branch January 9, 2025 04:22
Copy link

github-actions bot commented Jan 9, 2025

🎉 This PR is included in version 1.66.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants