Skip to content

Conversation

Ziinc
Copy link
Contributor

@Ziinc Ziinc commented Nov 28, 2023

This adjusts module naming to match the library name with the library namespace.

@filipecabaco
Copy link
Member

I was trying to follow the libcluster module naming: https://github.com/bitwalker/libcluster/blob/main/lib/strategy/dns_poll.ex

should we ignore and go with this route?

@Ziinc
Copy link
Contributor Author

Ziinc commented Nov 29, 2023

Having a separate namespace makes it clear to the users of the lib that it is not an inbuilt strategy, and prevents name clash if libcluster adds their own postgres strategy.

It's fine to keep it as is as well.

@Ziinc Ziinc merged commit f512aae into main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants