Merge pull request #200 from supabase/vars_0_4_0

Prep for v0.4.0 release

Makefile

@@ -1,5 +1,5 @@
 EXTENSION = pg_graphql
-DATA = pg_graphql--0.3.3.sql
+DATA = pg_graphql--0.4.0.sql
 
 PG_CONFIG = pg_config
 SHLIB_LINK = -lgraphqlparser

bin/common

@@ -1,4 +1,4 @@
-export PG_GRAPHQL_VERSION='0.3.3'
+export PG_GRAPHQL_VERSION='0.4.0'
 
 cli_log() {
   script_name=${0##*/}

pg_graphql--0.3.3.sql → pg_graphql--0.4.0.sql

@@ -2773,15 +2773,15 @@ begin
                 on je.k = f.name
         loop
 
+        -- Null should be ignored
+        if jsonb_typeof(variable_part) = 'null' or variable_part is null then
+            continue;
+        end if;
+
         comp_op = graphql.text_to_comparison_op(op_name);
 
         if comp_op = 'in' then
 
-            -- Null should be ignored
-            if jsonb_typeof(variable_part) = 'null' or variable_part is null then
-                continue;
-            end if;
-
             variable_part = graphql.arg_coerce_list(
                 variable_part
             ); -- this is now a jsonb array

pg_graphql.control

@@ -1,3 +1,3 @@
 comment = 'GraphQL support'
-default_version = '0.3.3'
+default_version = '0.4.0'
 relocatable = false

src/sql/resolve/clause/filter/where_clause.sql

@@ -75,15 +75,15 @@ begin
                 on je.k = f.name
         loop
 
+        -- Null should be ignored
+        if jsonb_typeof(variable_part) = 'null' or variable_part is null then
+            continue;
+        end if;
+
         comp_op = graphql.text_to_comparison_op(op_name);
 
         if comp_op = 'in' then
 
-            -- Null should be ignored
-            if jsonb_typeof(variable_part) = 'null' or variable_part is null then
-                continue;
-            end if;
-
             variable_part = graphql.arg_coerce_list(
                 variable_part
             ); -- this is now a jsonb array

test/expected/resolve_connection_filter.out

@@ -142,6 +142,14 @@ begin;
  }
 (1 row)
 
+    -- filter = null is ignored
+    select graphql.resolve($${accountCollection(filter: null) { edges { node { id } } }}$$);
+                                                   resolve                                                   
+-------------------------------------------------------------------------------------------------------------
+ {"data": {"accountCollection": {"edges": [{"node": {"id": 1}}, {"node": {"id": 2}}, {"node": {"id": 3}}]}}}
+(1 row)
+
+    rollback to savepoint a;
     -- neq
     select graphql.resolve($${accountCollection(filter: {id: {neq: 2}}) { edges { node { id } } }}$$);
                                         resolve                                         
@@ -157,6 +165,14 @@ begin;
  {"data": {"accountCollection": {"edges": [{"node": {"id": 1}}]}}}
 (1 row)
 
+    rollback to savepoint a;
+    -- lt - null - should be ignored
+    select graphql.resolve($${accountCollection(filter: {id: {lt: null}}) { edges { node { id } } }}$$);
+                                                   resolve                                                   
+-------------------------------------------------------------------------------------------------------------
+ {"data": {"accountCollection": {"edges": [{"node": {"id": 1}}, {"node": {"id": 2}}, {"node": {"id": 3}}]}}}
+(1 row)
+
     rollback to savepoint a;
     -- lte
     select graphql.resolve($${accountCollection(filter: {id: {lte: 2}}) { edges { node { id } } }}$$);

test/sql/resolve_connection_filter.sql

@@ -76,6 +76,10 @@ begin;
         $$)
     );
 
+    -- filter = null is ignored
+    select graphql.resolve($${accountCollection(filter: null) { edges { node { id } } }}$$);
+    rollback to savepoint a;
+
     -- neq
     select graphql.resolve($${accountCollection(filter: {id: {neq: 2}}) { edges { node { id } } }}$$);
     rollback to savepoint a;
@@ -84,6 +88,10 @@ begin;
     select graphql.resolve($${accountCollection(filter: {id: {lt: 2}}) { edges { node { id } } }}$$);
     rollback to savepoint a;
 
+    -- lt - null - should be ignored
+    select graphql.resolve($${accountCollection(filter: {id: {lt: null}}) { edges { node { id } } }}$$);
+    rollback to savepoint a;
+
     -- lte
     select graphql.resolve($${accountCollection(filter: {id: {lte: 2}}) { edges { node { id } } }}$$);
     rollback to savepoint a;