bugfix: arguments with null default were required #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imor
changed the title
olirice
approved these changes
Apr 8, 2024
| let trimmed = default_str.trim(); | ||
| if trimmed.starts_with("NULL::") { |
There was a problem hiding this comment.
are you confident this is always reliable wrt uppercase/lowercase? Will it alway be cast with a ::?
There was a problem hiding this comment.
are you confident this is always reliable wrt uppercase/lowercase?
Yes, Postgres converts all cases into capitals. Added a test for this.
Will it alway be cast with a ::?
A <arg> <type> default null form is always converted into a cast of the form NULL::<type>. Other, more complex forms of expressions might not work.
There was a problem hiding this comment.
Also updated docs with the caveat that only simple default null are supported for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
UDF args with a default value of null were either required or had a default value of "NULL" in case of string.
What is the new behavior?
UDF args with a null default value will be optional.
Additional context
Fixes #507