Updated API docs, removed dated comments #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The delete, post, and get function signatures included warnings about the ignored timeout argument. However, the extension's timeout feature has already been fixed. It is no longer necessary to retain these warnings.
…PI docs Added net.http_delete function to the API docs and removed comments about ignored timeout parameters in request functions, as the issue has been resolved.
This was referenced May 18, 2023
Closed
steve-chavez
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Docs Update
What is the current behavior?
The API documentation does not include net.http_delete. Also each request function signature still contains a warning against the usage of timeout parameters, even though the bug that necessitated the warning had been resolved.
Please link any relevant issues here.
What is the new behavior?
Additional context
Add any other context or screenshots.