fix(postgres): remove unnecessary schemaFilter in tables query by id #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When retrieving a specific table by ID, the query incorrectly included a schemaFilter which could potentially cause issues with finding the table. The schemaFilter was unnecessarily applied in the context of querying by ID since IDs are unique across schemas.
What is the new behavior?
Removed the unnecessary schemaFilter when querying tables by ID. This makes the query more reliable and efficient when fetching a specific table by its unique identifier.
Additional context
This change affects the retrieve method in PostgresMetaTables when fetching a table by its ID. The fix ensures that tables are properly retrieved by ID regardless of their schema, as the ID itself is sufficient to uniquely identify the table.