Map postgres numeric type to Swift Decimal type #960
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR updates the Swift type generator, mapping the postgres
numeric
type to Swift'sDecimal
type.What is the current behavior?
Currently, when generating a Swift type for a table that includes a column with a
numeric
type, the resulting Swift struct's property for that column isNumericSelect
, a consequence of the generator reachingsrc/server/templates/swift.ts#L347
.As a result, any generated Swift struct that contains
NumericSelect
will not compile due to the undefined type.What is the new behavior?
These changes simply sets the the
swiftType = 'Decimal'
whenpgType === numeric
.Additional context
Add any other context or screenshots.